Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8087557: [Win] [Accessibility, Dialogs] Alert Dialog content is not fully read by Screen Reader #115

Closed
wants to merge 2 commits into from

Conversation

arapte
Copy link
Member

@arapte arapte commented Nov 22, 2022

Not clean compared to jfx mainline.
But clean when backported from jfx17u.
Created this PR using commit hash from jfx17u.

The @since tag still needs to modified, trying this fist commit to test if the PR will be marked as clean.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8087557: [Win] [Accessibility, Dialogs] Alert Dialog content is not fully read by Screen Reader

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx11u pull/115/head:pull/115
$ git checkout pull/115

Update a local copy of the PR:
$ git checkout pull/115
$ git pull https://git.openjdk.org/jfx11u pull/115/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 115

View PR using the GUI difftool:
$ git pr show -t 115

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx11u/pull/115.diff

…ully read by Screen Reader

Reviewed-by: kcr
Backport-of: b951503134bdbc607cfa7a5ff05937f70a1a13dd
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2022

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 22, 2022

⚠️ @arapte could not find any commit with hash 4d86a0e5cd25748dee4c89bbc5ed2bc612e64e39. Please update the title with the hash for an existing commit.

@openjdk openjdk bot changed the title Backport 4d86a0e5cd25748dee4c89bbc5ed2bc612e64e39 8087557: [Win] [Accessibility, Dialogs] Alert Dialog content is not fully read by Screen Reader Nov 22, 2022
@openjdk
Copy link

openjdk bot commented Nov 22, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 22, 2022

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8087557: [Win] [Accessibility, Dialogs] Alert Dialog content is not fully read by Screen Reader

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Ready to be integrated rfr Ready for review labels Nov 22, 2022
@openjdk openjdk bot removed clean ready Ready to be integrated labels Nov 22, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2022

Webrevs

@openjdk openjdk bot added the ready Ready to be integrated label Nov 22, 2022
@arapte
Copy link
Member Author

arapte commented Nov 23, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 23, 2022

Going to push as commit 01e115e.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 16db452: 8291087: Wrong position of focus of screen reader on Windows with screen scale > 1

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 23, 2022
@openjdk openjdk bot closed this Nov 23, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Nov 23, 2022
@openjdk
Copy link

openjdk bot commented Nov 23, 2022

@arapte Pushed as commit 01e115e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants