Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
/ jfx11u Public archive

8089986: Menu beeps when mnemonics is used #127

Closed
wants to merge 1 commit into from

Conversation

arapte
Copy link
Member

@arapte arapte commented Feb 2, 2023

Almost clean backport, with a difference in copyright year. Otherwise clean.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx11u pull/127/head:pull/127
$ git checkout pull/127

Update a local copy of the PR:
$ git checkout pull/127
$ git pull https://git.openjdk.org/jfx11u pull/127/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 127

View PR using the GUI difftool:
$ git pr show -t 127

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx11u/pull/127.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 2, 2023

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c798d07a79debb00abb95a293e576237ee63a3b0 8089986: Menu beeps when mnemonics is used Feb 2, 2023
@openjdk
Copy link

openjdk bot commented Feb 2, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Ready for review labels Feb 2, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 2, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 2, 2023

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8089986: Menu beeps when mnemonics is used

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Feb 2, 2023
@arapte
Copy link
Member Author

arapte commented Feb 3, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 3, 2023

Going to push as commit 509d6cf.
Since your change was applied there has been 1 commit pushed to the master branch:

  • a78d6a9: 8299272: Update copyright header for files modified in 2022

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 3, 2023
@openjdk openjdk bot closed this Feb 3, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Feb 3, 2023
@openjdk
Copy link

openjdk bot commented Feb 3, 2023

@arapte Pushed as commit 509d6cf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants