Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264928: Update to Xcode 12.4 #14

Closed

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented May 8, 2021

Almost clean backport to jfx11u (clean except for surrounding context in build.properties). Tested on all three platforms, along with my other in-progress backports, all of which are aggregated in my kevinrushforth:test-kcr-11.0.12 branch.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx11u pull/14/head:pull/14
$ git checkout pull/14

Update a local copy of the PR:
$ git checkout pull/14
$ git pull https://git.openjdk.java.net/jfx11u pull/14/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14

View PR using the GUI difftool:
$ git pr show -t 14

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx11u/pull/14.diff

Reviewed-by: arapte, jvos
@kevinrushforth kevinrushforth requested a review from johanvos May 8, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 8, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c8384a1b544fa322b359ceca8bd3df21aae92c56 8264928: Update to Xcode 12.4 May 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 8, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented May 8, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264928: Update to Xcode 12.4

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 8, 2021

Webrevs

@kevinrushforth kevinrushforth removed the request for review from johanvos May 8, 2021
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented May 10, 2021

/integrate

@openjdk openjdk bot closed this May 10, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 10, 2021

@kevinrushforth Since your change was applied there have been 10 commits pushed to the master branch:

  • 63f9631: 8262276: Debug build of WebKit fails
  • 724dae3: 8263788: JavaFX application freezes completely after some time when using the WebView
  • 346cf7d: 8264990: WebEngine crashes with segfault when not loaded through system classloader
  • 5b2b9f9: 8259356: MediaPlayer's seek freezes video
  • 5ab6c40: 8259555: Webkit crashes on Apple Silicon
  • 32fda11: 8211294: ScrollPane content is blurry with 125% scaling
  • debddf7: 8258381: [macos] Exception when input emoji using Chinese input method
  • 26b5960: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop
  • 6ff7384: 8240539: Upgrade gradle to version 6.3
  • fdd0fa0: 8204568: Relative CSS-Attributes don't work all time

Your commit was automatically rebased without conflicts.

Pushed as commit dfe8909.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the kevinrushforth:8264928-xcode-12.4 branch May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant