Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268152: gstmpegaudioparse does not provides timestamps for HLS MP3 streams #22

Closed

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jun 5, 2021

This is a clean backport of a GStreamer audio fix for a regression caused by the recent GStreamer 1.18.3 update in JDK-8262365. I tested it on all three platforms.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268152: gstmpegaudioparse does not provides timestamps for HLS MP3 streams

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx11u pull/22/head:pull/22
$ git checkout pull/22

Update a local copy of the PR:
$ git checkout pull/22
$ git pull https://git.openjdk.java.net/jfx11u pull/22/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22

View PR using the GUI difftool:
$ git pr show -t 22

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx11u/pull/22.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 5, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ee032387badadb41ed36de745aea3c0a074b79bd 8268152: gstmpegaudioparse does not provides timestamps for HLS MP3 streams Jun 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 5, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 5, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268152: gstmpegaudioparse does not provides timestamps for HLS MP3 streams

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 5, 2021
@kevinrushforth kevinrushforth marked this pull request as ready for review Jun 5, 2021
@openjdk openjdk bot added the rfr label Jun 5, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 5, 2021

Webrevs

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Jun 5, 2021

/integrate

@openjdk openjdk bot closed this Jun 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 5, 2021

@kevinrushforth Pushed as commit 032368a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8268152-gstaudio branch Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant