Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8216377: JavaFX: memoryleak for initial nodes of Window #23

Closed
wants to merge 1 commit into from

Conversation

johanvos
Copy link
Collaborator

@johanvos johanvos commented Jun 8, 2021

8207837: Indeterminate ProgressBar does not animate if content is added after scene is set on window

Add or remove the windowShowingChangedListener when the scene changes

Reviewed-by: arapte, kcr


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8216377: JavaFX: memoryleak for initial nodes of Window
  • JDK-8207837: Indeterminate ProgressBar does not animate if content is added after scene is set on window

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx11u pull/23/head:pull/23
$ git checkout pull/23

Update a local copy of the PR:
$ git checkout pull/23
$ git pull https://git.openjdk.java.net/jfx11u pull/23/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23

View PR using the GUI difftool:
$ git pr show -t 23

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx11u/pull/23.diff

8207837: Indeterminate ProgressBar does not animate if content is added after scene is set on window

Add or remove the windowShowingChangedListener when the scene changes

Reviewed-by: arapte, kcr
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 8, 2021

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e21606d3a1b73cd4b44383babc750a4b4721edfd 8216377: JavaFX: memoryleak for initial nodes of Window Jun 8, 2021
@openjdk
Copy link

openjdk bot commented Jun 8, 2021

This backport pull request has now been updated with issues and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 8, 2021

@johanvos This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8216377: JavaFX: memoryleak for initial nodes of Window
8207837: Indeterminate ProgressBar does not animate if content is added after scene is set on window

Add or remove the windowShowingChangedListener when the scene changes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Ready to be integrated rfr Ready for review labels Jun 8, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 8, 2021

Webrevs

@johanvos
Copy link
Collaborator Author

johanvos commented Jun 9, 2021

/integrate

@openjdk openjdk bot closed this Jun 9, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels Jun 9, 2021
@openjdk
Copy link

openjdk bot commented Jun 9, 2021

@johanvos Pushed as commit 8af39d6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants