Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260245: Update ICU4C to version 68.2 #3

Closed

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented May 5, 2021

Backport ICU update from jfx mainline to jfx11u. The backport was clean except for a minor diff in the surrounding context in build.gradle. I ran a sanity test on Windows (I'll test on other two platforms before integrating).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8260245: Update ICU4C to version 68.2
  • JDK-8232379: Need to remove large icudt64l.zip binary file from source repository

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx11u pull/3/head:pull/3
$ git checkout pull/3

Update a local copy of the PR:
$ git checkout pull/3
$ git pull https://git.openjdk.java.net/jfx11u pull/3/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3

View PR using the GUI difftool:
$ git pr show -t 3

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx11u/pull/3.diff

8232379: Need to remove large icudt64l.zip binary file from source repository

Reviewed-by: kcr, jvos
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 5, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@kevinrushforth kevinrushforth marked this pull request as draft May 5, 2021
@kevinrushforth kevinrushforth changed the title 8260245: Update ICU4C to version 68.2 Backport 808b1078f762a923bd5e74298daffeb88ed108c2 May 5, 2021
@kevinrushforth kevinrushforth marked this pull request as ready for review May 5, 2021
@openjdk openjdk bot changed the title Backport 808b1078f762a923bd5e74298daffeb88ed108c2 8260245: Update ICU4C to version 68.2 May 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 5, 2021

This backport pull request has now been updated with issues from the original commit.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 5, 2021

Webrevs

@kevinrushforth kevinrushforth requested a review from johanvos May 5, 2021
Copy link
Collaborator

@johanvos johanvos left a comment

Works fine on Linux, still doing mac but no problems so far

@openjdk
Copy link

@openjdk openjdk bot commented May 5, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260245: Update ICU4C to version 68.2
8232379: Need to remove large icudt64l.zip binary file from source repository

Reviewed-by: jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 1c7d8dc: 8262366: Update glib to version 2.66.7

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 5, 2021
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented May 5, 2021

/integrate

@openjdk openjdk bot closed this May 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 5, 2021

@kevinrushforth Since your change was applied there has been 1 commit pushed to the master branch:

  • 1c7d8dc: 8262366: Update glib to version 2.66.7

Your commit was automatically rebased without conflicts.

Pushed as commit 81feeb2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the kevinrushforth:8260245-icu-68.2 branch May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants