New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8260245: Update ICU4C to version 68.2 #3
Conversation
8232379: Need to remove large icudt64l.zip binary file from source repository Reviewed-by: kcr, jvos
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issues from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine on Linux, still doing mac but no problems so far
@kevinrushforth This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@kevinrushforth Since your change was applied there has been 1 commit pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 81feeb2. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport ICU update from jfx mainline to jfx11u. The backport was clean except for a minor diff in the surrounding context in
build.gradle
. I ran a sanity test on Windows (I'll test on other two platforms before integrating).Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx11u pull/3/head:pull/3
$ git checkout pull/3
Update a local copy of the PR:
$ git checkout pull/3
$ git pull https://git.openjdk.java.net/jfx11u pull/3/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3
View PR using the GUI difftool:
$ git pr show -t 3
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx11u/pull/3.diff