Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8211308: Support HTTP/2 in WebView #30

Closed

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Aug 17, 2021

Clean backport of HTTP/2. This is enabled by default only with running with JDK 12 or later.

I have tested this with both JDK 11, where I verified that it HTTP/2 is not enabled, and JDK 15, where I verified that it HTTP/2 is enabled.

As an FYI, I tested this patch in my test-kcr-11.0.13 branch, which has the aggregate set of patches for the following bugs: JDK-8211308, JDK-8268915, JDK-8269147, JDK-8269131, JDK-8268849, JDK-8270479, JDK-8272329.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx11u pull/30/head:pull/30
$ git checkout pull/30

Update a local copy of the PR:
$ git checkout pull/30
$ git pull https://git.openjdk.java.net/jfx11u pull/30/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30

View PR using the GUI difftool:
$ git pr show -t 30

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx11u/pull/30.diff

@kevinrushforth kevinrushforth requested a review from johanvos Aug 17, 2021
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Aug 17, 2021

@johanvos Even though this is a clean backport, I'd like you to review it before I integrate it.

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 17, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 98035cb2afef0c230d55095f0addeab73693d0ac 8211308: Support HTTP/2 in WebView Aug 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 17, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 17, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8211308: Support HTTP/2 in WebView

Reviewed-by: jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • 0dd8eed: 8265400: Update to gcc 10.3 on Linux
  • 5185c67: 8268718: [macos] Video stops, but audio continues to play when stopTime is reached
  • e9433d6: 8231558: [macos] Platform.exit causes assertion error on macOS 10.15 or later
  • cb152a8: 8268219: hlsprogressbuffer should provide PTS after GStreamer update
  • 2eca451: 8267819: CoInitialize/CoUninitialize should be called on same thread
  • 097780d: 8266860: [macos] Incorrect duration reported for HLS live streams
  • b2c1622: 8264737: JavaFX media stream stops playing after reconnecting via Remote Desktop
  • 215aa17: 8271230: Remove obsolete test classes and data files from 3DViewer sample
  • 78855b1: 8266462: Update copyright years of javafx.web native sources in jfx11u
  • 906b61c: 8272329: Cherry pick GTK WebKit 2.32.3 changes
  • ... and 6 more: https://git.openjdk.java.net/jfx11u/compare/330b4fadb0f3b76f77f0338f26b90979605518c8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Aug 17, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 17, 2021

Webrevs

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Aug 19, 2021

@johanvos Did you want to review this before I integrate it?

@johanvos
Copy link
Collaborator

@johanvos johanvos commented Aug 19, 2021

@johanvos Did you want to review this before I integrate it?

I'm testing, will have a result in < 4 hours from now

Copy link
Collaborator

@johanvos johanvos left a comment

basic tests work as expected.
We should probably add this to the release notes.

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Aug 19, 2021

We should probably add this to the release notes.

Good idea.

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Aug 19, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 19, 2021

Going to push as commit 3f691c6.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 3a1e780: 8267892: Add .gitattributes to repo
  • fdbf327: 8267858: Document that title property in WebEngine gets updated asynchronously
  • 3aa3f19: 8267121: Illegal access to private "size" field of ArrayList from build.gradle
  • 0dd8eed: 8265400: Update to gcc 10.3 on Linux
  • 5185c67: 8268718: [macos] Video stops, but audio continues to play when stopTime is reached
  • e9433d6: 8231558: [macos] Platform.exit causes assertion error on macOS 10.15 or later
  • cb152a8: 8268219: hlsprogressbuffer should provide PTS after GStreamer update
  • 2eca451: 8267819: CoInitialize/CoUninitialize should be called on same thread
  • 097780d: 8266860: [macos] Incorrect duration reported for HLS live streams
  • b2c1622: 8264737: JavaFX media stream stops playing after reconnecting via Remote Desktop
  • ... and 9 more: https://git.openjdk.java.net/jfx11u/compare/330b4fadb0f3b76f77f0338f26b90979605518c8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 19, 2021

@kevinrushforth Pushed as commit 3f691c6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8211308-https-2 branch Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
3 participants