New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8211308: Support HTTP/2 in WebView #30
Conversation
Reviewed-by: ghb, kcr
@johanvos Even though this is a clean backport, I'd like you to review it before I integrate it. |
|
This backport pull request has now been updated with issue from the original commit. |
@kevinrushforth This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 16 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
@johanvos Did you want to review this before I integrate it? |
I'm testing, will have a result in < 4 hours from now |
basic tests work as expected.
We should probably add this to the release notes.
Good idea. |
/integrate |
Going to push as commit 3f691c6.
Your commit was automatically rebased without conflicts. |
@kevinrushforth Pushed as commit 3f691c6. |
Clean backport of HTTP/2. This is enabled by default only with running with JDK 12 or later.
I have tested this with both JDK 11, where I verified that it HTTP/2 is not enabled, and JDK 15, where I verified that it HTTP/2 is enabled.
As an FYI, I tested this patch in my test-kcr-11.0.13 branch, which has the aggregate set of patches for the following bugs: JDK-8211308, JDK-8268915, JDK-8269147, JDK-8269131, JDK-8268849, JDK-8270479, JDK-8272329.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx11u pull/30/head:pull/30
$ git checkout pull/30
Update a local copy of the PR:
$ git checkout pull/30
$ git pull https://git.openjdk.java.net/jfx11u pull/30/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30
View PR using the GUI difftool:
$ git pr show -t 30
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx11u/pull/30.diff