New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8268849: Update to 612.1 version of WebKit #34
Conversation
Co-authored-by: Arun Joseph <ajoseph@openjdk.org> Reviewed-by: kcr, jvos
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@kevinrushforth |
There are two follow-on issues that depend on this one, each of which has a Draft PR out for review: PR #35 and PR #36. As soon as this PR is ready, I will update those two PRs with the latest master (including the commit for this PR) and make them |
@kevinrushforth This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 929b9c2.
Your commit was automatically rebased without conflicts. |
@kevinrushforth Pushed as commit 929b9c2. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Nearly clean backport of third-party update to WebKit 612.1. There was one minor conflict in one unit test file due to difference in context.
As an FYI, I tested this patch in my test-kcr-11.0.13 branch, which has the aggregate set of patches for the following bugs: JDK-8211308, JDK-8268915, JDK-8269147, JDK-8269131, JDK-8268849, JDK-8270479, JDK-8272329.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx11u pull/34/head:pull/34
$ git checkout pull/34
Update a local copy of the PR:
$ git checkout pull/34
$ git pull https://git.openjdk.java.net/jfx11u pull/34/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 34
View PR using the GUI difftool:
$ git pr show -t 34
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx11u/pull/34.diff