Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271230: Remove obsolete test classes and data files from 3DViewer sample #37

Closed

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Aug 18, 2021

Clean backport to remove obsolete 3DViewer tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8271230: Remove obsolete test classes and data files from 3DViewer sample

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx11u pull/37/head:pull/37
$ git checkout pull/37

Update a local copy of the PR:
$ git checkout pull/37
$ git pull https://git.openjdk.java.net/jfx11u pull/37/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 37

View PR using the GUI difftool:
$ git pr show -t 37

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx11u/pull/37.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 18, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0e5b7887075e8cbe4d2b332c9021ec997f567ed7 8271230: Remove obsolete test classes and data files from 3DViewer sample Aug 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271230: Remove obsolete test classes and data files from 3DViewer sample

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Aug 18, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2021

Going to push as commit 215aa17.

@openjdk openjdk bot closed this Aug 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2021

@kevinrushforth Pushed as commit 215aa17.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 18, 2021

Webrevs

@kevinrushforth kevinrushforth deleted the 8271230-rm-3DViewer-test branch Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant