Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259680: Need API to query states of CAPS LOCK and NUM LOCK keys #4

Closed

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented May 5, 2021

This is the backport of a small enhancement to add a query for CAPS_LOCK and NUM_LOCK to jfx11u.

The jfx mainline patch applied cleanly except for one conflict in an import statement which had to be manually resolved. I also needed to subsequently modify the @since tag in the new API method to reflect the change in release, as noted in the CSR.

I've sanity tested it on Windows. I will sanity test on Linux and Mac before integrating.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259680: Need API to query states of CAPS LOCK and NUM LOCK keys

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx11u pull/4/head:pull/4
$ git checkout pull/4

Update a local copy of the PR:
$ git checkout pull/4
$ git pull https://git.openjdk.java.net/jfx11u pull/4/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4

View PR using the GUI difftool:
$ git pr show -t 4

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx11u/pull/4.diff

@kevinrushforth kevinrushforth requested a review from johanvos May 5, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 5, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 217a8cba5d68f6468fec8b33753b31430d3309da 8259680: Need API to query states of CAPS LOCK and NUM LOCK keys May 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 5, 2021

This backport pull request has now been updated with issue from the original commit.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 5, 2021

Webrevs

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented May 5, 2021

Verified on Mac and Linux as well.

@openjdk
Copy link

@openjdk openjdk bot commented May 5, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259680: Need API to query states of CAPS LOCK and NUM LOCK keys

Reviewed-by: jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 81feeb2: 8260245: Update ICU4C to version 68.2
  • 1c7d8dc: 8262366: Update glib to version 2.66.7

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 5, 2021
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented May 5, 2021

/integrate

@openjdk openjdk bot closed this May 5, 2021
@openjdk openjdk bot added integrated and removed ready labels May 5, 2021
@kevinrushforth kevinrushforth deleted the 8259680-caps-lock branch May 5, 2021
@openjdk openjdk bot removed the rfr label May 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 5, 2021

@kevinrushforth Since your change was applied there have been 2 commits pushed to the master branch:

  • 81feeb2: 8260245: Update ICU4C to version 68.2
  • 1c7d8dc: 8262366: Update glib to version 2.66.7

Your commit was automatically rebased without conflicts.

Pushed as commit ea4f880.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants