Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268718: [macos] Video stops, but audio continues to play when stopTime is reached #43

Closed
wants to merge 1 commit into from

Conversation

arapte
Copy link
Member

@arapte arapte commented Aug 19, 2021

This is clean backport.
Tested the patch in a branch.
Backports tested in above branch are :
JDK-8264737, JDK-8266860, JDK-8267819, JDK-8268219, JDK-8231558,
JDK-8268718, JDK-8265400, JDK-8267121, JDK-8267858, JDK-8267892


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8268718: [macos] Video stops, but audio continues to play when stopTime is reached

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx11u pull/43/head:pull/43
$ git checkout pull/43

Update a local copy of the PR:
$ git checkout pull/43
$ git pull https://git.openjdk.java.net/jfx11u pull/43/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 43

View PR using the GUI difftool:
$ git pr show -t 43

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx11u/pull/43.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 19, 2021

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0c98d9608611aa2378b38604e2528935c94e84ae 8268718: [macos] Video stops, but audio continues to play when stopTime is reached Aug 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 19, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 19, 2021

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268718: [macos] Video stops, but audio continues to play when stopTime is reached

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Aug 19, 2021
@arapte
Copy link
Member Author

@arapte arapte commented Aug 19, 2021

/integrate

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 19, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Aug 19, 2021

Going to push as commit 5185c67.

@openjdk openjdk bot closed this Aug 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 19, 2021

@arapte Pushed as commit 5185c67.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant