8268718: [macos] Video stops, but audio continues to play when stopTime is reached #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is clean backport.
Tested the patch in a branch.
Backports tested in above branch are :
JDK-8264737, JDK-8266860, JDK-8267819, JDK-8268219, JDK-8231558,
JDK-8268718, JDK-8265400, JDK-8267121, JDK-8267858, JDK-8267892
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx11u pull/43/head:pull/43
$ git checkout pull/43
Update a local copy of the PR:
$ git checkout pull/43
$ git pull https://git.openjdk.java.net/jfx11u pull/43/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 43
View PR using the GUI difftool:
$ git pr show -t 43
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx11u/pull/43.diff