New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8263760: Update gradle to version 7.0.1 #49
Conversation
8240336: JavaFX build uses deprecated features that will be removed in gradle 7 Reviewed-by: sykora, arapte
|
This backport pull request has now been updated with issues from the original commit. |
Webrevs
|
/reviewers 2 |
@kevinrushforth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine with a couple comments. I tested it with the older gradle 6.3
as well as 7.0.1
.
build.gradle
Outdated
@@ -2755,9 +2755,9 @@ project(":fxpackager") { | |||
} | |||
|
|||
dependencies { | |||
antpluginCompile group: "org.apache.ant", name: "ant", version: "1.8.2" | |||
implementation group: "org.apache.ant", name: "ant", version: "1.8.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be antpluginImplementation
? It may not matter as much, since we don't build fxpackager by default in FX 11, but I still think it should be fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is corrected in next commit.
/issue add 8262236 |
@arapte |
@johanvos can you also review this? |
Already did, but forgot to look at the results. Looks good to me. We might remove the fxpackager part, but it doesn't hurt being there either. |
@arapte This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
Thanks.
Since they aren't being built (and might no longer be buildable), we could consider backporting JDK-8203379 to jfx11u remove the sources in a future update release. As it is, these sources serve no purpose other than as a source of "technical debt". |
/integrate |
Going to push as commit 80c0670. |
There were two minor merge conflicts in
build.gradle
and one conflict ingradle/wrapper/gradle-wrapper.properties
while cherry picking the change.And it also required similar changes to be made for project fxpackager. The first commit is the original cherry pick and second commit is the additional changes for fxpackager.
Verified the build on all three platforms with gradle 7.0.1 and apache ant 1.10.5
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx11u pull/49/head:pull/49
$ git checkout pull/49
Update a local copy of the PR:
$ git checkout pull/49
$ git pull https://git.openjdk.java.net/jfx11u pull/49/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 49
View PR using the GUI difftool:
$ git pr show -t 49
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx11u/pull/49.diff