Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.
/ jfx11u Public archive

8275138: WebView: UserAgent string is empty for first request #57

Closed
wants to merge 1 commit into from
Closed

8275138: WebView: UserAgent string is empty for first request #57

wants to merge 1 commit into from

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Nov 5, 2021

Clean backport.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8275138: WebView: UserAgent string is empty for first request

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx11u pull/57/head:pull/57
$ git checkout pull/57

Update a local copy of the PR:
$ git checkout pull/57
$ git pull https://git.openjdk.java.net/jfx11u pull/57/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 57

View PR using the GUI difftool:
$ git pr show -t 57

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx11u/pull/57.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 5, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d6f78e27a698925f029126b8d62a3e88d4d6f868 8275138: WebView: UserAgent string is empty for first request Nov 5, 2021
@openjdk
Copy link

openjdk bot commented Nov 5, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 5, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275138: WebView: UserAgent string is empty for first request

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Ready to be integrated rfr Ready for review labels Nov 5, 2021
@kevinrushforth
Copy link
Member Author

/integrate

@mlbridge
Copy link

mlbridge bot commented Nov 5, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 5, 2021

Going to push as commit d9c0729.
Since your change was applied there have been 2 commits pushed to the master branch:

  • acab9b3: 8263807: Button types of a DialogPane are set twice, returns a wrong button
  • 54062a2: 8274413: FX: Update copyright year in docs, readme files to 2022

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 5, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels Nov 5, 2021
@openjdk
Copy link

openjdk bot commented Nov 5, 2021

@kevinrushforth Pushed as commit d9c0729.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8275138-user-agent branch November 5, 2021 15:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant