Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
/ jfx11u Public archive

8204568: Relative CSS-Attributes don't work all time #6

Closed
wants to merge 1 commit into from

Conversation

arapte
Copy link
Member

@arapte arapte commented May 7, 2021

Backport had a minor merge conflict of copyright year in the file Labeled.java.
Rest of the changes are clean backport


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8204568: Relative CSS-Attributes don't work all time

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx11u pull/6/head:pull/6
$ git checkout pull/6

Update a local copy of the PR:
$ git checkout pull/6
$ git pull https://git.openjdk.java.net/jfx11u pull/6/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6

View PR using the GUI difftool:
$ git pr show -t 6

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx11u/pull/6.diff

Reviewed-by: dgrieve, kcr, aghaisas
@bridgekeeper
Copy link

bridgekeeper bot commented May 7, 2021

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9c7cf172791c48ad419868045dd886968a2c4be8 8204568: Relative CSS-Attributes don't work all time May 7, 2021
@openjdk
Copy link

openjdk bot commented May 7, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Ready for review labels May 7, 2021
@mlbridge
Copy link

mlbridge bot commented May 7, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented May 8, 2021

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8204568: Relative CSS-Attributes don't work all time

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label May 8, 2021
@arapte
Copy link
Member Author

arapte commented May 10, 2021

/integrate

@openjdk openjdk bot closed this May 10, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels May 10, 2021
@openjdk
Copy link

openjdk bot commented May 10, 2021

@arapte Pushed as commit fdd0fa0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@arapte arapte deleted the backport_8204568 branch August 9, 2022 12:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants