New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8278980: Update WebKit to 613.1 #77
Conversation
Co-authored-by: Ajit Ghaisas <aghaisas@openjdk.org> Co-authored-by: Jay Bhaskar <jay.bhaskar@oracle.com> Co-authored-by: Kevin Rushforth <kcr@openjdk.org> Reviewed-by: kcr, jvos, aghaisas
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
@arapte Can you review to confirm that the backport was done cleanly? |
This backport pull request has now been updated with issue from the original commit. |
Verified that the backport is clean. and there was no diff except copyright year. |
@kevinrushforth This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 1057d01.
Your commit was automatically rebased without conflicts. |
@kevinrushforth Pushed as commit 1057d01. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Nearly clean backport to
jfx11u
(the only conflict was in the copyright years in one of the unit tests). I tested this along with the other VS 2019 and WebKit 613.1 fixes together in thetest-kcr-11.0.15
branch.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx11u pull/77/head:pull/77
$ git checkout pull/77
Update a local copy of the PR:
$ git checkout pull/77
$ git pull https://git.openjdk.java.net/jfx11u pull/77/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 77
View PR using the GUI difftool:
$ git pr show -t 77
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx11u/pull/77.diff