Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop #8

Closed
wants to merge 1 commit into from

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented May 8, 2021

This is a mostly-clean backport to jfx11u. The only merge conflicts I had to fix were in D3DPipeline.cc to ignore two hunks from the patch, since the static library support is not present in 11 (this is the exact same thing I had to do for the FX 8u backport).

Tested on all three platforms, along with my other in-progress backports, all of which are aggregated in my kevinrushforth:test-kcr-11.0.12 branch.

Additional testing: verified on a remote desktop connection that disconnecting and reconnecting now works.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx11u pull/8/head:pull/8
$ git checkout pull/8

Update a local copy of the PR:
$ git checkout pull/8
$ git pull https://git.openjdk.java.net/jfx11u pull/8/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8

View PR using the GUI difftool:
$ git pr show -t 8

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx11u/pull/8.diff

…ktop

Co-authored-by: Oliver Schmidtmer <O.Schmidtmer@elo.com>
Co-authored-by: Kevin Rushforth <kcr@openjdk.org>
Reviewed-by: arapte, ajoseph
@kevinrushforth kevinrushforth requested a review from johanvos May 8, 2021
@bridgekeeper
Copy link

bridgekeeper bot commented May 8, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 73e70fe978dda9fc821061dfc12bfb742dd7dc25 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop May 8, 2021
@openjdk
Copy link

openjdk bot commented May 8, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels May 8, 2021
@mlbridge
Copy link

mlbridge bot commented May 8, 2021

Webrevs

Copy link
Collaborator

@johanvos johanvos left a comment

looks good

@openjdk
Copy link

openjdk bot commented May 10, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop

Reviewed-by: jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 6ff7384: 8240539: Upgrade gradle to version 6.3
  • fdd0fa0: 8204568: Relative CSS-Attributes don't work all time

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 10, 2021
@kevinrushforth
Copy link
Member Author

kevinrushforth commented May 10, 2021

/integrate

@openjdk openjdk bot closed this May 10, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 10, 2021
@openjdk
Copy link

openjdk bot commented May 10, 2021

@kevinrushforth Since your change was applied there have been 2 commits pushed to the master branch:

  • 6ff7384: 8240539: Upgrade gradle to version 6.3
  • fdd0fa0: 8204568: Relative CSS-Attributes don't work all time

Your commit was automatically rebased without conflicts.

Pushed as commit 26b5960.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8239589-rdp branch May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants