Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
/ jfx11u Public archive

8197991: Selecting many items in a TableView is very slow #82

Closed
wants to merge 1 commit into from

Conversation

johanvos
Copy link
Collaborator

@johanvos johanvos commented Mar 17, 2022

Co-authored-by: Naohiro Yoshimoto yosbits@gmail.com
Reviewed-by: kcr, aghaisas


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8197991: Selecting many items in a TableView is very slow

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx11u pull/82/head:pull/82
$ git checkout pull/82

Update a local copy of the PR:
$ git checkout pull/82
$ git pull https://git.openjdk.java.net/jfx11u pull/82/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 82

View PR using the GUI difftool:
$ git pr show -t 82

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx11u/pull/82.diff

Co-authored-by: Naohiro Yoshimoto <yosbits@gmail.com>
Reviewed-by: kcr, aghaisas
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 17, 2022

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8c4f966b163f68c517574e38c394b9349551ad08 8197991: Selecting many items in a TableView is very slow Mar 17, 2022
@openjdk
Copy link

openjdk bot commented Mar 17, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 17, 2022

@johanvos This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8197991: Selecting many items in a TableView is very slow

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Ready to be integrated rfr Ready for review labels Mar 17, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 17, 2022

Webrevs

@johanvos
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 18, 2022

Going to push as commit 1c3d966.
Since your change was applied there has been 1 commit pushed to the master branch:

  • bf32dd8: 8203463: [Accessibility, Narrator] NPE in TableView

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 18, 2022
@openjdk openjdk bot closed this Mar 18, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Mar 18, 2022
@openjdk
Copy link

openjdk bot commented Mar 18, 2022

@johanvos Pushed as commit 1c3d966.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants