Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283328: Update libxml2 to 2.9.13 #84

Closed
wants to merge 1 commit into from

Conversation

johanvos
Copy link
Collaborator

@johanvos johanvos commented Apr 20, 2022

Reviewed-by: jvos, kcr, arapte


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx11u pull/84/head:pull/84
$ git checkout pull/84

Update a local copy of the PR:
$ git checkout pull/84
$ git pull https://git.openjdk.java.net/jfx11u pull/84/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 84

View PR using the GUI difftool:
$ git pr show -t 84

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx11u/pull/84.diff

Reviewed-by: jvos, kcr, arapte
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 20, 2022

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b0f2521219efc1b0d0c45088736d5105712bc2c9 8283328: Update libxml2 to 2.9.13 Apr 20, 2022
@openjdk
Copy link

openjdk bot commented Apr 20, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Apr 20, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 20, 2022

Webrevs

@kevinrushforth
Copy link
Member

kevinrushforth commented Apr 20, 2022

I confirm that this is a clean backport, but Skara failed to detect that it was clean due to SKARA-1332.

/clean

@openjdk openjdk bot added the clean label Apr 20, 2022
@openjdk
Copy link

openjdk bot commented Apr 20, 2022

@kevinrushforth This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Apr 20, 2022

@johanvos This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283328: Update libxml2 to 2.9.13

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 20, 2022
@johanvos
Copy link
Collaborator Author

johanvos commented Apr 20, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 20, 2022

Going to push as commit 1b214b0.

@openjdk openjdk bot added the integrated label Apr 20, 2022
@openjdk openjdk bot closed this Apr 20, 2022
@openjdk openjdk bot removed ready rfr labels Apr 20, 2022
@openjdk
Copy link

openjdk bot commented Apr 20, 2022

@johanvos Pushed as commit 1b214b0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants