Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280840: Update libFFI to 3.4.2 #93

Closed
wants to merge 1 commit into from

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Apr 30, 2022

Clean backport to jfx11u. Tested in connection with gstreamer / glib update in the test-kcr-11.0.16 branch.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx11u pull/93/head:pull/93
$ git checkout pull/93

Update a local copy of the PR:
$ git checkout pull/93
$ git pull https://git.openjdk.java.net/jfx11u pull/93/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 93

View PR using the GUI difftool:
$ git pr show -t 93

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx11u/pull/93.diff

Reviewed-by: kcr, sykora
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 30, 2022

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1beb3235223452929ec951ee18dd30a5345307cf 8280840: Update libFFI to 3.4.2 Apr 30, 2022
@openjdk
Copy link

openjdk bot commented Apr 30, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 30, 2022

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280840: Update libFFI to 3.4.2

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Ready to be integrated rfr Ready for review labels Apr 30, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 30, 2022

Webrevs

@kevinrushforth
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 2, 2022

Going to push as commit 1e4862f.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 44e691e: 8274274: Update JUnit to version 5.8.1
  • e877f30: 8281564: Update cmake to 3.22.3
  • e92f7fc: 8276142: Update gradle to version 7.3
  • 1e62db9: 8273998: Clarify specification for Window properties controlled by the window manager

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 2, 2022
@openjdk openjdk bot closed this May 2, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels May 2, 2022
@openjdk
Copy link

openjdk bot commented May 2, 2022

@kevinrushforth Pushed as commit 1e4862f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8280840-libffi branch May 2, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant