Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274274: Update JUnit to version 5.8.1 #97

Closed
wants to merge 1 commit into from

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Apr 30, 2022

Nearly clean backport to jfx11u. It isn't a clean backport since the mainline patch updated gradle/verification-metadata.xml, which doesn't exist in 11.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx11u pull/97/head:pull/97
$ git checkout pull/97

Update a local copy of the PR:
$ git checkout pull/97
$ git pull https://git.openjdk.java.net/jfx11u pull/97/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 97

View PR using the GUI difftool:
$ git pr show -t 97

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx11u/pull/97.diff

Reviewed-by: kcr, mstrauss, jvos
@kevinrushforth
Copy link
Member Author

kevinrushforth commented Apr 30, 2022

Reviewer: @arapte

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 30, 2022

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ff6e8d50badd57549811391b1380707bb94ac55b 8274274: Update JUnit to version 5.8.1 Apr 30, 2022
@openjdk
Copy link

openjdk bot commented Apr 30, 2022

This backport pull request has now been updated with issue from the original commit.

@mlbridge
Copy link

mlbridge bot commented Apr 30, 2022

Webrevs

arapte
arapte approved these changes May 2, 2022
@openjdk
Copy link

openjdk bot commented May 2, 2022

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274274: Update JUnit to version 5.8.1

Reviewed-by: arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • e92f7fc: 8276142: Update gradle to version 7.3
  • 1e62db9: 8273998: Clarify specification for Window properties controlled by the window manager

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label May 2, 2022
@kevinrushforth
Copy link
Member Author

kevinrushforth commented May 2, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 2, 2022

Going to push as commit 44e691e.
Since your change was applied there have been 3 commits pushed to the master branch:

  • e877f30: 8281564: Update cmake to 3.22.3
  • e92f7fc: 8276142: Update gradle to version 7.3
  • 1e62db9: 8273998: Clarify specification for Window properties controlled by the window manager

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 2, 2022
@openjdk openjdk bot closed this May 2, 2022
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels May 2, 2022
@openjdk
Copy link

openjdk bot commented May 2, 2022

@kevinrushforth Pushed as commit 44e691e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8274274-junit5 branch May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants