Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298167: Opacity in WebView not working anymore #111

Closed
wants to merge 1 commit into from
Closed

8298167: Opacity in WebView not working anymore #111

wants to merge 1 commit into from

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Feb 11, 2023

Clean backport. Tested in connection with 3 other WebKit fixes in the test-kcr-17.0.7 branch, including a successful CI build. I also verfied that the native WebKit code is identical to mainline jfx after applying all patches (excluding a couple of copyright years).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx17u pull/111/head:pull/111
$ git checkout pull/111

Update a local copy of the PR:
$ git checkout pull/111
$ git pull https://git.openjdk.org/jfx17u pull/111/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 111

View PR using the GUI difftool:
$ git pr show -t 111

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx17u/pull/111.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 11, 2023

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8136b11fdc75aba64d8b77cf286097db3e12d6c9 8298167: Opacity in WebView not working anymore Feb 11, 2023
@openjdk
Copy link

openjdk bot commented Feb 11, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 11, 2023

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298167: Opacity in WebView not working anymore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 11, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 11, 2023

Webrevs

@kevinrushforth
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 11, 2023

Going to push as commit e0b7eda.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 822dfe3: 8295755: Update SQLite to 3.39.4

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 11, 2023
@openjdk openjdk bot closed this Feb 11, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 11, 2023
@openjdk
Copy link

openjdk bot commented Feb 11, 2023

@kevinrushforth Pushed as commit e0b7eda.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8298167-webview-opacity branch February 11, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant