Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269374: Menu inoperable after setting stage to second monitor #12

Closed
wants to merge 1 commit into from

Conversation

johanvos
Copy link
Collaborator

@johanvos johanvos commented Sep 22, 2021

Clean backport of JDK-8269374 (already in 11.0.13)

Reviewed-by: kcr, arapte


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8269374: Menu inoperable after setting stage to second monitor

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx17u pull/12/head:pull/12
$ git checkout pull/12

Update a local copy of the PR:
$ git checkout pull/12
$ git pull https://git.openjdk.java.net/jfx17u pull/12/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12

View PR using the GUI difftool:
$ git pr show -t 12

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx17u/pull/12.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 22, 2021

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c490ddfdb1255add00dd7b0f14fe03857c6946c5 8269374: Menu inoperable after setting stage to second monitor Sep 22, 2021
@openjdk
Copy link

openjdk bot commented Sep 22, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 22, 2021

@johanvos This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269374: Menu inoperable after setting stage to second monitor

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 22, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 22, 2021

Webrevs

@johanvos
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 22, 2021

Going to push as commit 483e53b.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 9bd8708: 8273754: Re-introduce Automatic-Module-Name in empty jars

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 22, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 22, 2021
@openjdk
Copy link

openjdk bot commented Sep 22, 2021

@johanvos Pushed as commit 483e53b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant