Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296413: Tree/TableView with null focus model throws NPE in queryAccessibleAttribute() #124

Closed
wants to merge 1 commit into from

Conversation

johanvos
Copy link
Collaborator

@johanvos johanvos commented Mar 13, 2023

Almost clean patch (apart from 3 (c) dates) for
8296413: Tree/TableView with null focus model throws NPE in queryAccessibleAttribute()

Reviewed-by: arapte


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296413: Tree/TableView with null focus model throws NPE in queryAccessibleAttribute()

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx17u pull/124/head:pull/124
$ git checkout pull/124

Update a local copy of the PR:
$ git checkout pull/124
$ git pull https://git.openjdk.org/jfx17u pull/124/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 124

View PR using the GUI difftool:
$ git pr show -t 124

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx17u/pull/124.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 13, 2023

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e866a6c35c9040115dd62c6c04fd4b3d4d0e1324 8296413: Tree/TableView with null focus model throws NPE in queryAccessibleAttribute() Mar 13, 2023
@openjdk
Copy link

openjdk bot commented Mar 13, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 13, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 13, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 13, 2023

@johanvos This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296413: Tree/TableView with null focus model throws NPE in queryAccessibleAttribute()

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 13, 2023
@johanvos
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 14, 2023

Going to push as commit a094252.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 5ff6556: 8304098: [testbug] Test compilation failure in ControlUtils.java after JDK-8292353
  • 55f5576: 8303217: Webview loaded webpage is not showing play, volume related buttons for embeded Audio/Video elements
  • 2419ff3: 8301022: Video distortion is observed while playing youtube video
  • 0869711: 8302684: Cherry-pick WebKit 615.1 stabilization fixes (2)
  • 8aa7d21: 8302294: Cherry-pick WebKit 615.1 stabilization fixes

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 14, 2023
@openjdk openjdk bot closed this Mar 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 14, 2023
@openjdk
Copy link

openjdk bot commented Mar 14, 2023

@johanvos Pushed as commit a094252.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants