Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8303680: Virtual Flow freezes after calling scrollTo and scrollPixels in succession #155

Closed
wants to merge 1 commit into from

Conversation

jperedadnr
Copy link
Contributor

@jperedadnr jperedadnr commented Sep 6, 2023

Clean backport of 8303680: Virtual Flow freezes after calling scrollTo and scrollPixels in succession

Reviewed-by: angorya, jvos


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303680: Virtual Flow freezes after calling scrollTo and scrollPixels in succession (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx17u.git pull/155/head:pull/155
$ git checkout pull/155

Update a local copy of the PR:
$ git checkout pull/155
$ git pull https://git.openjdk.org/jfx17u.git pull/155/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 155

View PR using the GUI difftool:
$ git pr show -t 155

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx17u/pull/155.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 6, 2023

👋 Welcome back jpereda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6be8703ca9e6dccdda8b75b63efbcea5c6728d6f 8303680: Virtual Flow freezes after calling scrollTo and scrollPixels in succession Sep 6, 2023
@openjdk
Copy link

openjdk bot commented Sep 6, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 6, 2023

@jperedadnr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303680: Virtual Flow freezes after calling scrollTo and scrollPixels in succession

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • acf8acc: 8298728: Cells in VirtualFlow jump after resizing

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 6, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 6, 2023

Webrevs

@jperedadnr
Copy link
Contributor Author

Errors are due to branch not being up to date.

@jperedadnr jperedadnr closed this Sep 6, 2023
@jperedadnr jperedadnr deleted the backport-6be8703 branch September 6, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
2 participants