Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8324337: Cherry-pick WebKit 617.1 stabilization fixes #185

Closed

Conversation

johanvos
Copy link
Collaborator

@johanvos johanvos commented Mar 8, 2024


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8324337 needs maintainer approval

Issue

  • JDK-8324337: Cherry-pick WebKit 617.1 stabilization fixes (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx17u.git pull/185/head:pull/185
$ git checkout pull/185

Update a local copy of the PR:
$ git checkout pull/185
$ git pull https://git.openjdk.org/jfx17u.git pull/185/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 185

View PR using the GUI difftool:
$ git pr show -t 185

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx17u/pull/185.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 8, 2024

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 52840a17dee6a92fb9b1f3ff1b314b0ae228b95f 8324337: Cherry-pick WebKit 617.1 stabilization fixes Mar 8, 2024
@openjdk
Copy link

openjdk bot commented Mar 8, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 8, 2024

⚠️ @johanvos This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 8, 2024
@johanvos
Copy link
Collaborator Author

johanvos commented Mar 8, 2024

/approval request

@johanvos
Copy link
Collaborator Author

johanvos commented Mar 8, 2024

/approve yes

@openjdk
Copy link

openjdk bot commented Mar 8, 2024

@johanvos
8324337: The approval request has been created successfully.

@openjdk
Copy link

openjdk bot commented Mar 8, 2024

@johanvos
8324337: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Mar 8, 2024

@johanvos This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324337: Cherry-pick WebKit 617.1 stabilization fixes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 8, 2024
@johanvos
Copy link
Collaborator Author

johanvos commented Mar 8, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Mar 8, 2024

Going to push as commit 426f4eb.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 8, 2024
@openjdk openjdk bot closed this Mar 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 8, 2024
@openjdk
Copy link

openjdk bot commented Mar 8, 2024

@johanvos Pushed as commit 426f4eb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Mar 8, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant