Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273279: Change JavaFX release version in jfx17u to 17.0.1 #2

Closed
wants to merge 1 commit into from

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Sep 11, 2021

Bump release version in jfx17u repo to 17.0.1 for the start of a new release.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273279: Change JavaFX release version in jfx17u to 17.0.1

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx17u pull/2/head:pull/2
$ git checkout pull/2

Update a local copy of the PR:
$ git checkout pull/2
$ git pull https://git.openjdk.java.net/jfx17u pull/2/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2

View PR using the GUI difftool:
$ git pr show -t 2

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx17u/pull/2.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 11, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 11, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 11, 2021

Webrevs

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Sep 13, 2021

@johanvos can you review?

Copy link
Collaborator

@johanvos johanvos left a comment

trivial

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273279: Change JavaFX release version in jfx17u to 17.0.1

Reviewed-by: jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 14, 2021
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Sep 14, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

Going to push as commit d7c612f.
Since your change was applied there has been 1 commit pushed to the master branch:

  • d0f52c4: 8273280: Update README.md and CONTRIBUTING.md for jfx17u

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 14, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

@kevinrushforth Pushed as commit d7c612f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8273279-17.0.1 branch Sep 14, 2021
abhinayagarwal pushed a commit to abhinayagarwal/jfx17u that referenced this issue Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants