Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318984: Update to Xcode 14.3.1 on macOS #202

Closed

Conversation

sercher
Copy link
Contributor

@sercher sercher commented Sep 10, 2024

Hi all,

Please review a clean backport of d24e96a6 from the openjdk/jfx repository.

The fix being backported was authored by @kevinrushforth on 14 Nov 2023 and was reviewed by @arapte and @tiainen. This is part of the prerequisites for backporting WebKit 619.1 to OpenJFX 17.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8318984 needs maintainer approval

Issue

  • JDK-8318984: Update to Xcode 14.3.1 on macOS (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx17u.git pull/202/head:pull/202
$ git checkout pull/202

Update a local copy of the PR:
$ git checkout pull/202
$ git pull https://git.openjdk.org/jfx17u.git pull/202/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 202

View PR using the GUI difftool:
$ git pr show -t 202

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx17u/pull/202.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 10, 2024

👋 Welcome back schernyshev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 10, 2024

@sercher This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318984: Update to Xcode 14.3.1 on macOS

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport d24e96a66f1908b5a1a1a7d48ee938ba1c782e6c 8318984: Update to Xcode 14.3.1 on macOS Sep 10, 2024
@openjdk
Copy link

openjdk bot commented Sep 10, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 10, 2024

⚠️ @sercher This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 10, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 10, 2024

Webrevs

@sercher
Copy link
Contributor Author

sercher commented Sep 10, 2024

/approval request

@openjdk
Copy link

openjdk bot commented Sep 10, 2024

@sercher
8318984: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Sep 10, 2024
@johanvos
Copy link
Collaborator

/approve yes

@openjdk
Copy link

openjdk bot commented Sep 11, 2024

@johanvos
8318984: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 11, 2024
@johanvos
Copy link
Collaborator

/integrate

@openjdk
Copy link

openjdk bot commented Sep 11, 2024

@johanvos Only the author (@sercher) is allowed to issue the integrate command.

@johanvos
Copy link
Collaborator

@sercher Can you integrate this (and the other approved PR's)? I have a bunch of backports in the pipeline, but these ones should go first. Thanks!

@sercher
Copy link
Contributor Author

sercher commented Sep 11, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 11, 2024
@openjdk
Copy link

openjdk bot commented Sep 11, 2024

@sercher
Your change (at version 3f53b81) is now ready to be sponsored by a Committer.

@johanvos
Copy link
Collaborator

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 11, 2024

Going to push as commit a429abe.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 11, 2024
@openjdk openjdk bot closed this Sep 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 11, 2024
@openjdk
Copy link

openjdk bot commented Sep 11, 2024

@johanvos @sercher Pushed as commit a429abe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants