-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8318984: Update to Xcode 14.3.1 on macOS #202
8318984: Update to Xcode 14.3.1 on macOS #202
Conversation
👋 Welcome back schernyshev! A progress list of the required criteria for merging this PR into |
@sercher This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request |
/approve yes |
@johanvos |
/integrate |
@sercher Can you integrate this (and the other approved PR's)? I have a bunch of backports in the pipeline, but these ones should go first. Thanks! |
/integrate |
/sponsor |
Going to push as commit a429abe. |
Hi all,
Please review a clean backport of d24e96a6 from the openjdk/jfx repository.
The fix being backported was authored by @kevinrushforth on 14 Nov 2023 and was reviewed by @arapte and @tiainen. This is part of the prerequisites for backporting WebKit 619.1 to OpenJFX 17.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx17u.git pull/202/head:pull/202
$ git checkout pull/202
Update a local copy of the PR:
$ git checkout pull/202
$ git pull https://git.openjdk.org/jfx17u.git pull/202/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 202
View PR using the GUI difftool:
$ git pr show -t 202
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx17u/pull/202.diff
Webrev
Link to Webrev Comment