8315870: icu fails to compile with Visual Studio 2022 17.6.5

[johanvos]

Hi all,

This pull request contains a backport of commit ed92171 from the openjdk/jfx repository.

The commit being backported was authored by Kevin Rushforth on 8 Sep 2023 and was reviewed by Ambarish Rapte and Johan Vos.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8315870 needs maintainer approval

Warning

 ⚠️ Found leading lowercase letter in issue title for 8315870: icu fails to compile with Visual Studio 2022 17.6.5

Issue

• JDK-8315870: icu fails to compile with Visual Studio 2022 17.6.5 (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx17u.git pull/207/head:pull/207
$ git checkout pull/207

Update a local copy of the PR:
$ git checkout pull/207
$ git pull https://git.openjdk.org/jfx17u.git pull/207/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 207

View PR using the GUI difftool:
$ git pr show -t 207

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx17u/pull/207.diff

[bridgekeeper]

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@johanvos This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315870: icu fails to compile with Visual Studio 2022 17.6.5

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @johanvos This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[johanvos]

/approval request

[openjdk]

@johanvos
8315870: The approval request has been created successfully.

[johanvos]

/approve yes

[openjdk]

@johanvos
8315870: The approval request has been approved.

[johanvos]

/integrate

[openjdk]

Going to push as commit 20e4310.

[openjdk]

@johanvos Pushed as commit 20e4310.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[mlbridge]

Webrevs

• 00: Full (36efbf4b)