8345870: Failed to compile test/javafx/scene/web/CSSRoundingTest.java after 8336798

[sercher]

Hi,

this PR fixes the build failure after backporting JDK-8336798 [1].
The test CSSRoundingTest.java uses multiline string literals, that are not supported with -source 11.

[1] https://bugs.openjdk.org/browse/JDK-8336798

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8345870 needs maintainer approval

Issue

• JDK-8345870: Failed to compile test/javafx/scene/web/CSSRoundingTest.java after 8336798 (Bug - P4 - Approved)

Reviewers

• Johan Vos (@johanvos - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx17u.git pull/221/head:pull/221
$ git checkout pull/221

Update a local copy of the PR:
$ git checkout pull/221
$ git pull https://git.openjdk.org/jfx17u.git pull/221/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 221

View PR using the GUI difftool:
$ git pr show -t 221

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx17u/pull/221.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back schernyshev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sercher This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345870: Failed to compile test/javafx/scene/web/CSSRoundingTest.java after 8336798

Reviewed-by: jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@johanvos) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (92c8ee43)

[sercher]

@johanvos Could you please take a look?

[johanvos]

@sercher Thanks for spotting this -- makes sense indeed. I'll do a deeper review + tests later this week.

[johanvos]

tested, works fine now.

[openjdk]

⚠️ @sercher This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[sercher]

/approval request JFX17 builds are failing without the fix.

[openjdk]

@sercher
8345870: The approval request has been created successfully.

[johanvos]

/approve yes

[openjdk]

@johanvos
8345870: The approval request has been approved.

[sercher]

/integrate

[openjdk]

@sercher
Your change (at version 92c8ee4) is now ready to be sponsored by a Committer.

[johanvos]

/sponsor

[openjdk]

Going to push as commit f965b61.

[openjdk]

@johanvos @sercher Pushed as commit f965b61.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.