New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8268849: Update to 612.1 version of WebKit #3
Conversation
Co-authored-by: Arun Joseph <ajoseph@openjdk.org> Reviewed-by: kcr, jvos
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
For some reason, Skara didn't mark this as clean, so it needs a (sanity) review. @arapte Can you review? |
If we compare modules/javafx.web/src/main/native/Source of this repo with that of mainline webkit update revision. There are only differences of copyright year. jfx17 files have 2021 in copyright year. |
@kevinrushforth This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks for the review and the sanity check.
Right. The copyright updates in the |
/integrate |
Going to push as commit 092c20b.
Your commit was automatically rebased without conflicts. |
@kevinrushforth Pushed as commit 092c20b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport to
jfx17u
. This has been tested on all platforms along with other pending fixes in thetest-kcr-17.0.1
branch.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx17u pull/3/head:pull/3
$ git checkout pull/3
Update a local copy of the PR:
$ git checkout pull/3
$ git pull https://git.openjdk.java.net/jfx17u pull/3/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3
View PR using the GUI difftool:
$ git pr show -t 3
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx17u/pull/3.diff