-
Notifications
You must be signed in to change notification settings - Fork 18
8268718: [macos] Video stops, but audio continues to play when stopTime is reached #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8268718: [macos] Video stops, but audio continues to play when stopTime is reached #4
Conversation
…me is reached Reviewed-by: kcr, arapte
|
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@kevinrushforth This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit 3c6596b.
Your commit was automatically rebased without conflicts. |
|
@kevinrushforth Pushed as commit 3c6596b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Add missing method to jniconfig json
Clean backport to
jfx17u. This has been tested along with other pending fixes in thetest-kcr-17.0.1branch.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx17u pull/4/head:pull/4$ git checkout pull/4Update a local copy of the PR:
$ git checkout pull/4$ git pull https://git.openjdk.java.net/jfx17u pull/4/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4View PR using the GUI difftool:
$ git pr show -t 4Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx17u/pull/4.diff