Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273138: BidirectionalBinding fails to observe changes of invalid properties #5

Closed

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Sep 15, 2021

Clean backport to jfx17u. This has been tested along with other pending fixes in the test-kcr-17.0.1 branch.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273138: BidirectionalBinding fails to observe changes of invalid properties

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx17u pull/5/head:pull/5
$ git checkout pull/5

Update a local copy of the PR:
$ git checkout pull/5
$ git pull https://git.openjdk.java.net/jfx17u pull/5/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5

View PR using the GUI difftool:
$ git pr show -t 5

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx17u/pull/5.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 15, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 26d6438ea267d703039facac7dab67175b863b46 8273138: BidirectionalBinding fails to observe changes of invalid properties Sep 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273138: BidirectionalBinding fails to observe changes of invalid properties

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • d7c612f: 8273279: Change JavaFX release version in jfx17u to 17.0.1
  • d0f52c4: 8273280: Update README.md and CONTRIBUTING.md for jfx17u

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 15, 2021

Webrevs

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Sep 15, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2021

Going to push as commit ff4a625.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 3c6596b: 8268718: [macos] Video stops, but audio continues to play when stopTime is reached
  • d7c612f: 8273279: Change JavaFX release version in jfx17u to 17.0.1
  • d0f52c4: 8273280: Update README.md and CONTRIBUTING.md for jfx17u

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2021

@kevinrushforth Pushed as commit ff4a625.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8273138-bidi-bindings branch Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant