Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276553: ListView scrollTo() is broken after fix for JDK-8089589 #50

Closed
wants to merge 1 commit into from

Conversation

johanvos
Copy link
Collaborator

@johanvos johanvos commented Apr 30, 2022

Reviewed-by: kcr, mstrauss


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8276553: ListView scrollTo() is broken after fix for JDK-8089589

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx17u pull/50/head:pull/50
$ git checkout pull/50

Update a local copy of the PR:
$ git checkout pull/50
$ git pull https://git.openjdk.java.net/jfx17u pull/50/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 50

View PR using the GUI difftool:
$ git pr show -t 50

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx17u/pull/50.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 30, 2022

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d3fbb516c428876bd2389bbfd40f95a811ea6af8 8276553: ListView scrollTo() is broken after fix for JDK-8089589 Apr 30, 2022
@openjdk
Copy link

openjdk bot commented Apr 30, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 30, 2022

@johanvos This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276553: ListView scrollTo() is broken after fix for JDK-8089589

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 30, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 30, 2022

Webrevs

@johanvos
Copy link
Collaborator Author

johanvos commented May 2, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 2, 2022

Going to push as commit 83534e2.
Since your change was applied there have been 7 commits pushed to the master branch:

  • ca0e5a4: 8274137: TableView scrollbar/header misaligned when reloading data
  • 13ca8ee: 8284184: Crash in GraphicsContextJava::drawLinesForText on https://us.yahoo.com/
  • 367f3d5: 8270867: Debug build of WebKit 613.1 fails on Linux
  • 8e52c7b: 8280020: Underline and line-through not straight in WebView
  • cc835ba: 8269115: WebView paste event contains old data
  • ca7303c: 8255940: localStorage is null after window.close()
  • dd592f1: 8278759: PointerEvent: buttons property set to 0 when mouse down

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 2, 2022
@openjdk openjdk bot closed this May 2, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 2, 2022
@openjdk
Copy link

openjdk bot commented May 2, 2022

@johanvos Pushed as commit 83534e2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant