Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286261: Selection of non-expanded non-leaf treeItem grows unexpectedly when adding two-level descendants #70

Closed
wants to merge 1 commit into from

Conversation

johanvos
Copy link
Collaborator

@johanvos johanvos commented Jun 29, 2022

8286261: Selection of non-expanded non-leaf treeItem grows unexpectedly when adding two-level descendants

Reviewed-by: aghaisas


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8286261: Selection of non-expanded non-leaf treeItem grows unexpectedly when adding two-level descendants

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx17u pull/70/head:pull/70
$ git checkout pull/70

Update a local copy of the PR:
$ git checkout pull/70
$ git pull https://git.openjdk.org/jfx17u pull/70/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 70

View PR using the GUI difftool:
$ git pr show -t 70

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx17u/pull/70.diff

…ly when adding two-level descendants

Reviewed-by: aghaisas
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 29, 2022

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 29, 2022

⚠️ @johanvos the given backport hash 85ac440bc9581deb6027eabbc5c70b323725b8db is an ancestor of your proposed change. Please update the title with the hash for the change you are backporting.

@johanvos johanvos changed the title Backport 85ac440bc9581deb6027eabbc5c70b323725b8db Backport 19a855e8ec3972377359ecbc0f71808f34c1b288 Jun 30, 2022
@openjdk openjdk bot changed the title Backport 19a855e8ec3972377359ecbc0f71808f34c1b288 8286261: Selection of non-expanded non-leaf treeItem grows unexpectedly when adding two-level descendants Jun 30, 2022
@openjdk
Copy link

openjdk bot commented Jun 30, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 30, 2022

@johanvos This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286261: Selection of non-expanded non-leaf treeItem grows unexpectedly when adding two-level descendants

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 30, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 30, 2022

Webrevs

@johanvos
Copy link
Collaborator Author

johanvos commented Jul 4, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jul 4, 2022

Going to push as commit d3c26c4.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 4, 2022
@openjdk openjdk bot closed this Jul 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 4, 2022
@openjdk
Copy link

openjdk bot commented Jul 4, 2022

@johanvos Pushed as commit d3c26c4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant