Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272329: Cherry pick GTK WebKit 2.32.3 changes #8

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Sep 15, 2021

Clean backport to jfx17u. This has been tested on all platforms along with other pending fixes in the test-kcr-17.0.1 branch.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx17u pull/8/head:pull/8
$ git checkout pull/8

Update a local copy of the PR:
$ git checkout pull/8
$ git pull https://git.openjdk.java.net/jfx17u pull/8/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8

View PR using the GUI difftool:
$ git pr show -t 8

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx17u/pull/8.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ee442e516a20e979dc228ab63c6b795b74d49e41 8272329: Cherry pick GTK WebKit 2.32.3 changes Sep 15, 2021
@openjdk
Copy link

openjdk bot commented Sep 15, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 15, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272329: Cherry pick GTK WebKit 2.32.3 changes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 15, 2021
@kevinrushforth
Copy link
Member Author

kevinrushforth commented Sep 15, 2021

NOTE: I verified that after this PR and PR #7 are applied, modules/javafx.web/src/main/native is identical to the mainline jfx repo.

@mlbridge
Copy link

mlbridge bot commented Sep 15, 2021

Webrevs

@kevinrushforth
Copy link
Member Author

kevinrushforth commented Sep 15, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Sep 15, 2021

Going to push as commit 2947986.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 5397290: 8270479: WebKit 612.1 build fails with Visual Studio 2017

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 15, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 15, 2021
@openjdk
Copy link

openjdk bot commented Sep 15, 2021

@kevinrushforth Pushed as commit 2947986.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8272329-webkit-gtk-2.32.3 branch Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants