Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277785: ListView scrollTo jumps to wrong location when CellHeight is changed #86

Closed
wants to merge 1 commit into from

Conversation

johanvos
Copy link
Collaborator

@johanvos johanvos commented Oct 20, 2022

clean backport of 8277785: ListView scrollTo jumps to wrong location when CellHeight is…changed

Reviewed-by: kcr, fkirmaier, aghaisas


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8277785: ListView scrollTo jumps to wrong location when CellHeight is changed

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx17u pull/86/head:pull/86
$ git checkout pull/86

Update a local copy of the PR:
$ git checkout pull/86
$ git pull https://git.openjdk.org/jfx17u pull/86/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 86

View PR using the GUI difftool:
$ git pr show -t 86

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx17u/pull/86.diff

… changed

Reviewed-by: kcr, fkirmaier, aghaisas
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 20, 2022

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b8302f64f49e746a8645020cb778a4f3e4f4b893 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed Oct 20, 2022
@openjdk
Copy link

openjdk bot commented Oct 20, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 20, 2022

@johanvos This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277785: ListView scrollTo jumps to wrong location when CellHeight is changed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 20, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 20, 2022

Webrevs

@johanvos
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 23, 2022

Going to push as commit e3c85a8.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 7bef58e: 8284665: First selected item of a TreeItem multiple selection gets removed if new items are constantly added to the TreeTableView
  • aa7edf2: 8291625: DialogPane without header nor headerText nor graphic node adds padding to the left of the content pane

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 23, 2022
@openjdk openjdk bot closed this Oct 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 23, 2022
@openjdk
Copy link

openjdk bot commented Oct 23, 2022

@johanvos Pushed as commit e3c85a8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant