Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8087557: [Win] [Accessibility, Dialogs] Alert Dialog content is not fully read by Screen Reader #91

Closed
wants to merge 3 commits into from

Conversation

arapte
Copy link
Member

@arapte arapte commented Nov 21, 2022

Backport this a11y fix to jfx17u.
This is not a clean backport. The source code changes apply cleanly but there was a conflict in test file.
The test DialogTest.java file does not exist in jfx17u source.
The file is now added but only with one test that was added as part of this fix to mainline, and other pre-existing tests are removed.
Tested that fix works as expected on Windows and macOS


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8087557: [Win] [Accessibility, Dialogs] Alert Dialog content is not fully read by Screen Reader

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx17u pull/91/head:pull/91
$ git checkout pull/91

Update a local copy of the PR:
$ git checkout pull/91
$ git pull https://git.openjdk.org/jfx17u pull/91/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 91

View PR using the GUI difftool:
$ git pr show -t 91

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx17u/pull/91.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2022

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b951503134bdbc607cfa7a5ff05937f70a1a13dd 8087557: [Win] [Accessibility, Dialogs] Alert Dialog content is not fully read by Screen Reader Nov 21, 2022
@openjdk
Copy link

openjdk bot commented Nov 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 21, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 21, 2022

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Nov 21, 2022

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8087557: [Win] [Accessibility, Dialogs] Alert Dialog content is not fully read by Screen Reader

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 21, 2022
Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that the version number in the @since needs to be changed.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Nov 22, 2022
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 22, 2022
@arapte
Copy link
Member Author

arapte commented Nov 22, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 22, 2022

Going to push as commit 4d86a0e.
Since your change was applied there have been 3 commits pushed to the master branch:

  • f34d86d: 8291087: Wrong position of focus of screen reader on Windows with screen scale > 1
  • 76bbd59: 8283402: Update to gcc 11.2.0 on Linux
  • 04b3232: 8289541: Update ICU4C to 71.1

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 22, 2022
@openjdk openjdk bot closed this Nov 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 22, 2022
@openjdk
Copy link

openjdk bot commented Nov 22, 2022

@arapte Pushed as commit 4d86a0e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants