New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8087557: [Win] [Accessibility, Dialogs] Alert Dialog content is not fully read by Screen Reader #91
Conversation
…ully read by Screen Reader
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@arapte This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that the version number in the @since
needs to be changed.
modules/javafx.graphics/src/main/java/javafx/scene/AccessibleRole.java
Outdated
Show resolved
Hide resolved
/integrate |
Going to push as commit 4d86a0e.
Your commit was automatically rebased without conflicts. |
Backport this a11y fix to jfx17u.
This is not a clean backport. The source code changes apply cleanly but there was a conflict in test file.
The test
DialogTest.java
file does not exist in jfx17u source.The file is now added but only with one test that was added as part of this fix to mainline, and other pre-existing tests are removed.
Tested that fix works as expected on Windows and macOS
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx17u pull/91/head:pull/91
$ git checkout pull/91
Update a local copy of the PR:
$ git checkout pull/91
$ git pull https://git.openjdk.org/jfx17u pull/91/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 91
View PR using the GUI difftool:
$ git pr show -t 91
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx17u/pull/91.diff