Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

8302684: Cherry-pick WebKit 615.1 stabilization fixes (2) #6

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Mar 13, 2023

Clean backport to jfx20u. Tested in connection with all other WebKit backports in jfx-20.0.1 branch.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8302684: Cherry-pick WebKit 615.1 stabilization fixes (2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx20u pull/6/head:pull/6
$ git checkout pull/6

Update a local copy of the PR:
$ git checkout pull/6
$ git pull https://git.openjdk.org/jfx20u pull/6/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6

View PR using the GUI difftool:
$ git pr show -t 6

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx20u/pull/6.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 13, 2023

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 67c2b7a13b5d3378c1006b8fd3af28aa8eb49c25 8302684: Cherry-pick WebKit 615.1 stabilization fixes (2) Mar 14, 2023
@openjdk
Copy link

openjdk bot commented Mar 14, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 14, 2023

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302684: Cherry-pick WebKit 615.1 stabilization fixes (2)

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 14, 2023
@kevinrushforth
Copy link
Member Author

/integrate

@mlbridge
Copy link

mlbridge bot commented Mar 14, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 14, 2023

Going to push as commit 32a5055.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 14, 2023
@openjdk openjdk bot closed this Mar 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 14, 2023
@openjdk
Copy link

openjdk bot commented Mar 14, 2023

@kevinrushforth Pushed as commit 32a5055.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8302684-webkit-cherry-pick2 branch March 14, 2023 00:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant