-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8315870: icu fails to compile with Visual Studio 2022 17.6.5 #14
8315870: icu fails to compile with Visual Studio 2022 17.6.5 #14
Conversation
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Keep native WebKit in sync. Also, will eventually be needed for next compiler update. |
@kevinrushforth The approval request has been created successfully. |
/approval yes |
@kevinrushforth usage: |
/approve yes |
@kevinrushforth |
@kevinrushforth This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 400b8dd. |
@kevinrushforth Pushed as commit 400b8dd. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport to jfx21u.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx21u.git pull/14/head:pull/14
$ git checkout pull/14
Update a local copy of the PR:
$ git checkout pull/14
$ git pull https://git.openjdk.org/jfx21u.git pull/14/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 14
View PR using the GUI difftool:
$ git pr show -t 14
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx21u/pull/14.diff
Webrev
Link to Webrev Comment