Skip to content

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Oct 10, 2023

Release notes for JavaFX 21.0.1.

Notes to reviewers:

I used the following filter to pick the issues:

https://bugs.openjdk.org/issues/?filter=44663

The original filter, with the backport IDs, is here:

https://bugs.openjdk.org/issues/?filter=44662

As usual, I excluded test bugs, cleanup bugs, etc. I manually excludes 4 additional bugs, one of which was a README change (does not affect the product), and the other three were introduced and fixed in the same release.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8317842 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8317842: Create release notes for JavaFX 21.0.1 (Task - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx21u.git pull/19/head:pull/19
$ git checkout pull/19

Update a local copy of the PR:
$ git checkout pull/19
$ git pull https://git.openjdk.org/jfx21u.git pull/19/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19

View PR using the GUI difftool:
$ git pr show -t 19

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx21u/pull/19.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 10, 2023

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@kevinrushforth
Copy link
Member Author

Reviewers: @johanvos @abhinayagarwal

@kevinrushforth kevinrushforth marked this pull request as ready for review October 17, 2023 13:49
@kevinrushforth
Copy link
Member Author

There are no security fixes this time, so this PR is ready for final review.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 17, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 17, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 17, 2023

⚠️ @kevinrushforth This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Oct 17, 2023

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317842: Create release notes for JavaFX 21.0.1

Reviewed-by: jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • a043159: Merge
  • 6e9a982: 8315657: Application window not activated in macOS 14 Sonoma

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 17, 2023
@kevinrushforth
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 17, 2023

Going to push as commit e7ad06f.
Since your change was applied there have been 2 commits pushed to the master branch:

  • a043159: Merge
  • 6e9a982: 8315657: Application window not activated in macOS 14 Sonoma

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 17, 2023
@openjdk openjdk bot closed this Oct 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 17, 2023
@openjdk
Copy link

openjdk bot commented Oct 17, 2023

@kevinrushforth Pushed as commit e7ad06f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Oct 18, 2023

Mailing list message from Johan Vos on openjfx-dev:

Looks good, I'm double checking and will approve.
It would be a great future feature if we can somehow automatically remove
the issues that are introduced in the same version.

- Johan

Op di 17 okt 2023 om 16:10 schreef Kevin Rushforth <kcr at openjdk.org>:

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/openjfx-dev/attachments/20231017/c1266942/attachment.htm>

@mlbridge
Copy link

mlbridge bot commented Oct 18, 2023

Mailing list message from Johan Vos on openjfx-dev:

Hi Kevin,

After a second look, I'm not sure about excluding the issues with a
hgupdate-sync label. From a previous mail, I understood that those have to
be removed in the release notes of jfx22, but from the backports?

- Johan

On Tue, Oct 17, 2023 at 4:10?PM Kevin Rushforth <kcr at openjdk.org> wrote:

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/openjfx-dev/attachments/20231017/19c72d88/attachment-0001.htm>

@mlbridge
Copy link

mlbridge bot commented Oct 18, 2023

Mailing list message from Kevin Rushforth on openjfx-dev:

We need to exclude from the release notes any backport with a fix
version of 21.0.1 and an hgupdate-sync label. Those bugs were fixed in
21 and are already in the release notes for 21.

Do you have an example where you think the JBS filter excluded something
it should not have?

-- Kevin

On 10/17/2023 7:43 AM, Johan Vos wrote:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/openjfx-dev/attachments/20231017/0a536e59/attachment.htm>

@mlbridge
Copy link

mlbridge bot commented Oct 18, 2023

Mailing list message from Johan Vos on openjfx-dev:

No, you are right.
All good, I approved.

- Johan

On Tue, Oct 17, 2023 at 4:50?PM Kevin Rushforth <kevin.rushforth at oracle.com>
wrote:

We need to exclude from the release notes any backport with a fix version
of 21.0.1 and an hgupdate-sync label. Those bugs were fixed in 21 and are
already in the release notes for 21.

Do you have an example where you think the JBS filter excluded something
it should not have?

-- Kevin

On 10/17/2023 7:43 AM, Johan Vos wrote:

Hi Kevin,

After a second look, I'm not sure about excluding the issues with a
hgupdate-sync label. From a previous mail, I understood that those have to
be removed in the release notes of jfx22, but from the backports?

- Johan

On Tue, Oct 17, 2023 at 4:10?PM Kevin Rushforth <kcr at openjdk.org> wrote:

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/openjfx-dev/attachments/20231017/d4214c56/attachment-0001.htm>

@mlbridge
Copy link

mlbridge bot commented Oct 18, 2023

Mailing list message from Kevin Rushforth on openjfx-dev:

Thanks. To answer the one outstanding question from your earlier reply:

It would be a great?future feature if we can somehow automatically
remove the issues that are introduced in the same version.

Yes, it would. As of now, we don't have a robust way to do it,? but I'll
give it some thought.

-- Kevin

On 10/17/2023 7:53 AM, Johan Vos wrote:

No, you are right.
All good, I approved.

- Johan

On Tue, Oct 17, 2023 at 4:50?PM Kevin Rushforth
<kevin.rushforth at oracle.com> wrote:

We need to exclude from the release notes any backport with a fix
version of 21\.0\.1 and an hgupdate\-sync label\. Those bugs were
fixed in 21 and are already in the release notes for 21\.

Do you have an example where you think the JBS filter excluded
something it should not have\?

\-\- Kevin


On 10\/17\/2023 7\:43 AM\, Johan Vos wrote\:

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/openjfx-dev/attachments/20231017/0a77bc72/attachment.htm>

@kevinrushforth kevinrushforth deleted the 8317842-release-notes-21.0.1 branch January 17, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants