-
Notifications
You must be signed in to change notification settings - Fork 18
8317842: Create release notes for JavaFX 21.0.1 #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8317842: Create release notes for JavaFX 21.0.1 #19
Conversation
|
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
|
Reviewers: @johanvos @abhinayagarwal |
|
There are no security fixes this time, so this PR is ready for final review. |
|
|
|
@kevinrushforth This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
@kevinrushforth Pushed as commit e7ad06f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
|
Mailing list message from Johan Vos on openjfx-dev: Looks good, I'm double checking and will approve. - Johan Op di 17 okt 2023 om 16:10 schreef Kevin Rushforth <kcr at openjdk.org>: -------------- next part -------------- |
|
Mailing list message from Johan Vos on openjfx-dev: Hi Kevin, After a second look, I'm not sure about excluding the issues with a - Johan On Tue, Oct 17, 2023 at 4:10?PM Kevin Rushforth <kcr at openjdk.org> wrote: -------------- next part -------------- |
|
Mailing list message from Kevin Rushforth on openjfx-dev: We need to exclude from the release notes any backport with a fix Do you have an example where you think the JBS filter excluded something -- Kevin On 10/17/2023 7:43 AM, Johan Vos wrote: |
|
Mailing list message from Johan Vos on openjfx-dev: No, you are right. - Johan On Tue, Oct 17, 2023 at 4:50?PM Kevin Rushforth <kevin.rushforth at oracle.com>
-------------- next part -------------- |
|
Mailing list message from Kevin Rushforth on openjfx-dev: Thanks. To answer the one outstanding question from your earlier reply:
Yes, it would. As of now, we don't have a robust way to do it,? but I'll -- Kevin On 10/17/2023 7:53 AM, Johan Vos wrote:
-------------- next part -------------- |
Release notes for JavaFX 21.0.1.
Notes to reviewers:
I used the following filter to pick the issues:
https://bugs.openjdk.org/issues/?filter=44663
The original filter, with the backport IDs, is here:
https://bugs.openjdk.org/issues/?filter=44662
As usual, I excluded test bugs, cleanup bugs, etc. I manually excludes 4 additional bugs, one of which was a README change (does not affect the product), and the other three were introduced and fixed in the same release.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx21u.git pull/19/head:pull/19$ git checkout pull/19Update a local copy of the PR:
$ git checkout pull/19$ git pull https://git.openjdk.org/jfx21u.git pull/19/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19View PR using the GUI difftool:
$ git pr show -t 19Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx21u/pull/19.diff
Webrev
Link to Webrev Comment