Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319231: Unrecognized "minimum" key in .jcheck/conf causes /reviewers command to be ignored #24

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Nov 1, 2023

Clean backport to jfx21u.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8319231 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8319231: Unrecognized "minimum" key in .jcheck/conf causes /reviewers command to be ignored (Bug - P2 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx21u.git pull/24/head:pull/24
$ git checkout pull/24

Update a local copy of the PR:
$ git checkout pull/24
$ git pull https://git.openjdk.org/jfx21u.git pull/24/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24

View PR using the GUI difftool:
$ git pr show -t 24

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx21u/pull/24.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 1, 2023

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@kevinrushforth
Copy link
Member Author

/integrate auto

@openjdk openjdk bot changed the title Backport 72c052ee2ad7b1f74c3c57078917c719d66a9c10 8319231: Unrecognized "minimum" key in .jcheck/conf causes /reviewers command to be ignored Nov 1, 2023
@openjdk
Copy link

openjdk bot commented Nov 1, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review auto labels Nov 1, 2023
@openjdk
Copy link

openjdk bot commented Nov 1, 2023

@kevinrushforth This pull request will be automatically integrated when it is ready

@mlbridge
Copy link

mlbridge bot commented Nov 1, 2023

Webrevs

@andy-goryachev-oracle
Copy link
Contributor

andy-goryachev-oracle commented Nov 1, 2023

is the target branch correct?
edit: please disregard

@openjdk
Copy link

openjdk bot commented Nov 1, 2023

⚠️ @kevinrushforth This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Nov 1, 2023

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319231: Unrecognized "minimum" key in .jcheck/conf causes /reviewers command to be ignored

Reviewed-by: angorya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 1, 2023
@openjdk
Copy link

openjdk bot commented Nov 1, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Nov 1, 2023

Going to push as commit 916df93.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 1, 2023
@openjdk openjdk bot closed this Nov 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 1, 2023
@openjdk
Copy link

openjdk bot commented Nov 1, 2023

@openjdk[bot] Pushed as commit 916df93.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto backport clean integrated Pull request has been integrated
2 participants