Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318984: Update to Xcode 14.3.1 on macOS #27

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Nov 14, 2023

Clean backport of compiler update to jfx21u


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8318984 needs maintainer approval

Issue

  • JDK-8318984: Update to Xcode 14.3.1 on macOS (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx21u.git pull/27/head:pull/27
$ git checkout pull/27

Update a local copy of the PR:
$ git checkout pull/27
$ git pull https://git.openjdk.org/jfx21u.git pull/27/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27

View PR using the GUI difftool:
$ git pr show -t 27

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx21u/pull/27.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2023

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d24e96a66f1908b5a1a1a7d48ee938ba1c782e6c 8318984: Update to Xcode 14.3.1 on macOS Nov 14, 2023
@openjdk
Copy link

openjdk bot commented Nov 14, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 14, 2023

⚠️ @kevinrushforth This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 14, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 14, 2023

Webrevs

@kevinrushforth
Copy link
Member Author

/approval request We would like to keep jfx21u on the latest compiler toolchain versions

@openjdk
Copy link

openjdk bot commented Nov 14, 2023

@kevinrushforth
8318984: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 14, 2023
@openjdk
Copy link

openjdk bot commented Nov 15, 2023

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318984: Update to Xcode 14.3.1 on macOS

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 15, 2023
@kevinrushforth
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 15, 2023

Going to push as commit 5a1a12a.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 15, 2023
@openjdk openjdk bot closed this Nov 15, 2023
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Nov 15, 2023
@openjdk
Copy link

openjdk bot commented Nov 15, 2023

@kevinrushforth Pushed as commit 5a1a12a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant