-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8330462: StringIndexOutOfBoundException when typing anything into TextField #57
Conversation
👋 Welcome back jpereda! A progress list of the required criteria for merging this PR into |
@jperedadnr This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good
/integrate |
Going to push as commit 136dd66. |
@jperedadnr Pushed as commit 136dd66. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit d3da033a from the openjdk/jfx repository.
The commit being backported was authored by Oliver Kopp on 8 May 2024 and was reviewed by Andy Goryachev, Kevin Rushforth and Ambarish Rapte.
The backport is almost clean: While cherry picking the mainline commit, a minor merge conflict was shown at the file
tests/system/src/test/.classpath
: The mainline file has a few additional exports compared to 21u, which are not needed here.Thanks!
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx21u.git pull/57/head:pull/57
$ git checkout pull/57
Update a local copy of the PR:
$ git checkout pull/57
$ git pull https://git.openjdk.org/jfx21u.git pull/57/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 57
View PR using the GUI difftool:
$ git pr show -t 57
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx21u/pull/57.diff
Webrev
Link to Webrev Comment