Skip to content

8318388: Update libxslt to 1.1.39#75

Closed
johanvos wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-johanvos-09922d5c-master
Closed

8318388: Update libxslt to 1.1.39#75
johanvos wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-johanvos-09922d5c-master

Conversation

@johanvos
Copy link
Contributor

@johanvos johanvos commented Nov 21, 2024

Hi all,

This pull request contains a backport of commit 09922d5 from the openjdk/jfx repository.

The commit being backported was authored by Hima Bindu Meda on 5 Dec 2023 and was reviewed by Kevin Rushforth and Joeri Sykora.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8318388 needs maintainer approval

Issue

  • JDK-8318388: Update libxslt to 1.1.39 (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx21u.git pull/75/head:pull/75
$ git checkout pull/75

Update a local copy of the PR:
$ git checkout pull/75
$ git pull https://git.openjdk.org/jfx21u.git pull/75/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 75

View PR using the GUI difftool:
$ git pr show -t 75

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx21u/pull/75.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2024

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 21, 2024

@johanvos This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318388: Update libxslt to 1.1.39

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 09922d5c030aa4d82a477f2c1ca27de052f0543d 8318388: Update libxslt to 1.1.39 Nov 21, 2024
@openjdk
Copy link

openjdk bot commented Nov 21, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 21, 2024
@openjdk
Copy link

openjdk bot commented Nov 21, 2024

⚠️ @johanvos This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review ready Pull request is ready to be integrated labels Nov 21, 2024
@johanvos
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 21, 2024

Going to push as commit ed66e50.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 21, 2024
@openjdk openjdk bot closed this Nov 21, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 21, 2024
@openjdk
Copy link

openjdk bot commented Nov 21, 2024

@johanvos Pushed as commit ed66e50.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Nov 21, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant