Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8337481: File API: file.name contains path instead of name #80

Conversation

johanvos
Copy link

@johanvos johanvos commented Nov 21, 2024

Hi all,

This pull request contains a backport of commit ca70a07b from the openjdk/jfx repository.

The commit being backported was authored by Oliver Schmidtmer on 30 Aug 2024 and was reviewed by Ambarish Rapte and Hima Bindu Meda.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8337481 needs maintainer approval

Issue

  • JDK-8337481: File API: file.name contains path instead of name (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx21u.git pull/80/head:pull/80
$ git checkout pull/80

Update a local copy of the PR:
$ git checkout pull/80
$ git pull https://git.openjdk.org/jfx21u.git pull/80/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 80

View PR using the GUI difftool:
$ git pr show -t 80

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx21u/pull/80.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2024

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 21, 2024

@johanvos This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337481: File API: file.name contains path instead of name

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • b7cd0d9: 8336798: DRT test cssrounding.html test for linear layout fails with WebKit 619.1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport ca70a07b3ee712b1d06baf8a3901e6ae96070124 8337481: File API: file.name contains path instead of name Nov 21, 2024
@openjdk
Copy link

openjdk bot commented Nov 21, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 21, 2024

⚠️ @johanvos This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review ready Pull request is ready to be integrated labels Nov 21, 2024
@johanvos
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 21, 2024

Going to push as commit c00126e.
Since your change was applied there has been 1 commit pushed to the master branch:

  • b7cd0d9: 8336798: DRT test cssrounding.html test for linear layout fails with WebKit 619.1

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 21, 2024
@openjdk openjdk bot closed this Nov 21, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 21, 2024
@openjdk
Copy link

openjdk bot commented Nov 21, 2024

@johanvos Pushed as commit c00126e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Nov 21, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant