Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jfx22u Public archive

Conversation

andy-goryachev-oracle
Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle commented Apr 3, 2024

Hi all,

This pull request contains a backport of commit 483c6408 from the openjdk/jfx repository.

The commit being backported was authored by Andy Goryachev on 3 Apr 2024 and was reviewed by Kevin Rushforth and Hima Bindu Meda.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8328752 needs maintainer approval

Issue

  • JDK-8328752: Fix missing @Overrides in javafx.web (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx22u.git pull/23/head:pull/23
$ git checkout pull/23

Update a local copy of the PR:
$ git checkout pull/23
$ git pull https://git.openjdk.org/jfx22u.git pull/23/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23

View PR using the GUI difftool:
$ git pr show -t 23

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx22u/pull/23.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 3, 2024

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 3, 2024

@andy-goryachev-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328752: Fix missing @Overrides in javafx.web

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 483c64082f7752e239c5630eb1d7895e599e5dda 8328752: Fix missing @Overrides in javafx.web Apr 3, 2024
@openjdk
Copy link

openjdk bot commented Apr 3, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 3, 2024

⚠️ @andy-goryachev-oracle This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 3, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 3, 2024

Webrevs

@andy-goryachev-oracle
Copy link
Contributor Author

/approval request backport this change to ensure WebKit sources are identical across the releases

@openjdk
Copy link

openjdk bot commented Apr 3, 2024

@andy-goryachev-oracle
8328752: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Apr 3, 2024
@kevinrushforth
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Apr 3, 2024

@kevinrushforth
8328752: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 3, 2024
@andy-goryachev-oracle
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 3, 2024

Going to push as commit e657264.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 3, 2024
@openjdk openjdk bot closed this Apr 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 3, 2024
@openjdk
Copy link

openjdk bot commented Apr 3, 2024

@andy-goryachev-oracle Pushed as commit e657264.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants