-
Notifications
You must be signed in to change notification settings - Fork 8
8328752: Fix missing @Overrides in javafx.web #23
8328752: Fix missing @Overrides in javafx.web #23
Conversation
👋 Welcome back angorya! A progress list of the required criteria for merging this PR into |
@andy-goryachev-oracle This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request backport this change to ensure WebKit sources are identical across the releases |
@andy-goryachev-oracle |
/approve yes |
@kevinrushforth |
/integrate |
Going to push as commit e657264. |
@andy-goryachev-oracle Pushed as commit e657264. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit 483c6408 from the openjdk/jfx repository.
The commit being backported was authored by Andy Goryachev on 3 Apr 2024 and was reviewed by Kevin Rushforth and Hima Bindu Meda.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx22u.git pull/23/head:pull/23
$ git checkout pull/23
Update a local copy of the PR:
$ git checkout pull/23
$ git pull https://git.openjdk.org/jfx22u.git pull/23/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23
View PR using the GUI difftool:
$ git pr show -t 23
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx22u/pull/23.diff
Webrev
Link to Webrev Comment