Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jfx22u Public archive

8329705: Add missing Application thread checks to platform specific a11y methods #25

Closed

Conversation

azuev-java
Copy link
Member

@azuev-java azuev-java commented Apr 5, 2024

Backport from mainline. Changes can be applied cleanly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8329705 needs maintainer approval

Issue

  • JDK-8329705: Add missing Application thread checks to platform specific a11y methods (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx22u.git pull/25/head:pull/25
$ git checkout pull/25

Update a local copy of the PR:
$ git checkout pull/25
$ git pull https://git.openjdk.org/jfx22u.git pull/25/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25

View PR using the GUI difftool:
$ git pr show -t 25

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx22u/pull/25.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 5, 2024

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329705: Add missing Application thread checks to platform specific a11y methods

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 0eb4d7196099d817cc6467985b882242845bdd2e 8329705: Add missing Application thread checks to platform specific a11y methods Apr 5, 2024
@openjdk
Copy link

openjdk bot commented Apr 5, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

⚠️ @azuev-java This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 5, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 5, 2024

Webrevs

@azuev-java
Copy link
Member Author

/approval request Backport of a stability fix that affects accessibility on macOS and Windows

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

@azuev-java
8329705: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Apr 5, 2024
@kevinrushforth
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

@kevinrushforth
8329705: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 5, 2024
@azuev-java
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 5, 2024
@openjdk
Copy link

openjdk bot commented Apr 5, 2024

@azuev-java
Your change (at version 64fdc3c) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

Going to push as commit 1e21a6f.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 5, 2024
@openjdk openjdk bot closed this Apr 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 5, 2024
@openjdk
Copy link

openjdk bot commented Apr 5, 2024

@kevinrushforth @azuev-java Pushed as commit 1e21a6f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants