Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8322251: [Linux] JavaFX is not displaying CJK on Ubuntu 23.10 and later #27

Closed
wants to merge 1 commit into from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Apr 25, 2024

Backport to jfx22u


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8322251 needs maintainer approval

Issue

  • JDK-8322251: [Linux] JavaFX is not displaying CJK on Ubuntu 23.10 and later (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx22u.git pull/27/head:pull/27
$ git checkout pull/27

Update a local copy of the PR:
$ git checkout pull/27
$ git pull https://git.openjdk.org/jfx22u.git pull/27/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27

View PR using the GUI difftool:
$ git pr show -t 27

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx22u/pull/27.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2024

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 25, 2024

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322251: [Linux] JavaFX is not displaying CJK on Ubuntu 23.10 and later

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 5182ea16ace78c4f61e2c38981aab62f6153294e 8322251: [Linux] JavaFX is not displaying CJK on Ubuntu 23.10 and later Apr 25, 2024
@openjdk
Copy link

openjdk bot commented Apr 25, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean approval rfr Pull request is ready for review labels Apr 25, 2024
@kevinrushforth
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Apr 25, 2024

@kevinrushforth
8322251: The approval request has been approved.

@mlbridge
Copy link

mlbridge bot commented Apr 25, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 25, 2024
@prrace
Copy link
Contributor Author

prrace commented Apr 25, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 25, 2024

Going to push as commit 77e7e25.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 25, 2024
@openjdk openjdk bot closed this Apr 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 25, 2024
@openjdk
Copy link

openjdk bot commented Apr 25, 2024

@prrace Pushed as commit 77e7e25.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants