-
Notifications
You must be signed in to change notification settings - Fork 8
8330462: StringIndexOutOfBoundException when typing anything into TextField #28
Conversation
…tField Reviewed-by: angorya, kcr, arapte
👋 Welcome back arapte! A progress list of the required criteria for merging this PR into |
@arapte This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Don't forget to also request maintainer approval (using the Skara command /approval request REASON FOR THE REQUEST
)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/approval request Important change that fixes an exception |
/skara approve yes |
@kevinrushforth |
/integrate |
Going to push as commit 2bfd9f6. |
The backport is almost clean.
While cherry picking the mainline commit, a minor merge conflict was shown in a the file
tests/system/src/test/.classpath
: The mainline file has a few additional exports compared to 22u.Test passes on windows.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx22u.git pull/28/head:pull/28
$ git checkout pull/28
Update a local copy of the PR:
$ git checkout pull/28
$ git pull https://git.openjdk.org/jfx22u.git pull/28/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28
View PR using the GUI difftool:
$ git pr show -t 28
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx22u/pull/28.diff
Webrev
Link to Webrev Comment