Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jfx22u Public archive

8330462: StringIndexOutOfBoundException when typing anything into TextField #28

Closed
wants to merge 1 commit into from

Conversation

arapte
Copy link
Member

@arapte arapte commented May 13, 2024

The backport is almost clean.
While cherry picking the mainline commit, a minor merge conflict was shown in a the file tests/system/src/test/.classpath : The mainline file has a few additional exports compared to 22u.

Test passes on windows.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8330462 needs maintainer approval

Issue

  • JDK-8330462: StringIndexOutOfBoundException when typing anything into TextField (Bug - P2 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx22u.git pull/28/head:pull/28
$ git checkout pull/28

Update a local copy of the PR:
$ git checkout pull/28
$ git pull https://git.openjdk.org/jfx22u.git pull/28/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28

View PR using the GUI difftool:
$ git pr show -t 28

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx22u/pull/28.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 13, 2024

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 13, 2024

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330462: StringIndexOutOfBoundException when typing anything into TextField

Reviewed-by: kcr, angorya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport d3da033a2dd5c287733545935242a8d1f71c0554 8330462: StringIndexOutOfBoundException when typing anything into TextField May 13, 2024
@openjdk
Copy link

openjdk bot commented May 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 13, 2024
@mlbridge
Copy link

mlbridge bot commented May 13, 2024

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Don't forget to also request maintainer approval (using the Skara command /approval request REASON FOR THE REQUEST)

@openjdk
Copy link

openjdk bot commented May 13, 2024

⚠️ @arapte This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arapte
Copy link
Member Author

arapte commented May 13, 2024

/approval request Important change that fixes an exception

@openjdk
Copy link

openjdk bot commented May 13, 2024

@arapte
8330462: The approval request has been created successfully.

@openjdk openjdk bot added the approval label May 13, 2024
@kevinrushforth
Copy link
Member

/skara approve yes

@openjdk
Copy link

openjdk bot commented May 13, 2024

@kevinrushforth
8330462: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 13, 2024
@arapte
Copy link
Member Author

arapte commented May 13, 2024

/integrate

@openjdk
Copy link

openjdk bot commented May 13, 2024

Going to push as commit 2bfd9f6.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 13, 2024
@openjdk openjdk bot closed this May 13, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 13, 2024
@openjdk
Copy link

openjdk bot commented May 13, 2024

@arapte Pushed as commit 2bfd9f6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants