Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jfx22u Public archive

8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13 #29

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented May 16, 2024

Clean backport of Linux GHA fix to jfx22u (so we can get clean GHA runs for future 22u backports)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8332328 needs maintainer approval

Issue

  • JDK-8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx22u.git pull/29/head:pull/29
$ git checkout pull/29

Update a local copy of the PR:
$ git checkout pull/29
$ git pull https://git.openjdk.org/jfx22u.git pull/29/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29

View PR using the GUI difftool:
$ git pr show -t 29

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx22u/pull/29.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 16, 2024

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 16, 2024

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13

Upgrade GHA Linux build platform to Ubuntu 24.04

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport d7ab55184f757a614f9fc8f191c3c5794a16cc88 8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13 May 16, 2024
@openjdk
Copy link

openjdk bot commented May 16, 2024

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented May 16, 2024

⚠️ @kevinrushforth This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 16, 2024
@mlbridge
Copy link

mlbridge bot commented May 16, 2024

Webrevs

@kevinrushforth
Copy link
Member Author

/skara approval request Only affects GHA runs, which are used for testing purposes. Without this fix, GHA runs will fail consistently on Linux.

@openjdk
Copy link

openjdk bot commented May 16, 2024

@kevinrushforth
8332328: The approval request has been created successfully.

@openjdk openjdk bot added the approval label May 16, 2024
@kevinrushforth
Copy link
Member Author

@johanvos Since this is a clean backport, it doesn't need to be reviewed, but it does need maintainer approval. It's not an urgent fix, but until it is integrated, all GHA runs in this repo will fail on Linux.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 17, 2024
@kevinrushforth
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 17, 2024

Going to push as commit e7545c6.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 17, 2024
@openjdk openjdk bot closed this May 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 17, 2024
@openjdk
Copy link

openjdk bot commented May 17, 2024

@kevinrushforth Pushed as commit e7545c6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant